Dahdi-2.6.2+2.6.2 not compiling

Asterisk Asterisk Support
1

Trying to build the latest release of dahdi-linux-complete 2.6.2+2.6.2 and the compile fails with the following errors:

[size=85]oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c: In function Oct6100ApiBridgeEventRemove:
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c:3870:47: error: NULL undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c:3870:47: note: each undeclared identifier is reported only once for each function it appears in
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c: In function Oct6100EventGetToneDef:
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c:89:32: error: NULL undeclared (first use in this function)
.
.
.
oct612x/apilib/llman/octapi_llman.c: In function OctapiLlmAllocInit:
oct612x/apilib/llman/octapi_llman.c:88:12: error: NULL undeclared (first use in this function)
oct612x/apilib/llman/octapi_llman.c:88:12: note: each undeclared identifier is reported only once for each function it appears in
make[3]: *** [oct6100_adpcm_chan.o] Error 1
make[3]: Leaving directory /usr/local/src/askbuilder/dahdi/tools/xpp' make[2]: *** [utils-subdirs] Error 2 make[2]: Leaving directory/usr/local/src/askbuilder/dahdi/tools’
make[1]: *** [all] Error 2
make[1]: Leaving directory `/usr/local/src/askbuilder/dahdi/tools’
make: *** [all] Error 2
[/size]

My /proc/version: Linux version 3.5.0-25-generic (buildd@lamiak) (gcc version 4.7.2 (Ubuntu/Linaro 4.7.2-2ubuntu1) ) #39-Ubuntu SMP Mon Feb 25 19:02:34 UTC 2013

I received these errors initially after upgrading the OS from Ubuntu 12.04 from 12.10 Now the same problem is happening again. Someone had recommended a patch for this in November which corrected the problem. After I reapplying that same patch now to the 2.6.2+2.6.2 version everything appears fine.

My question is, will this patch be applied to some future release or is this some thing i will have to add to my steps each time I upgrade? Or worse, is this a patch i shouldn’t be applying? :wink: For what its worth I have been building dahdi/asterisk versions on this machine since 1.8.1 with no issues until now.

Here is the patch I applied:

[code]diff --git a/xpp/oct612x/include/octdef.h b/xpp/oct612x/include/octdef.h
index a2da33d…7e534b7 100644
— a/xpp/oct612x/include/octdef.h
+++ b/xpp/oct612x/include/octdef.h
@@ -39,6 +39,10 @@ $Octasic_Revision: 12 $
extern “C” {
#endif

+#ifndef KERNEL
+#include <stdio.h>
+#endif
+
/***************************** INCLUDE FILES *******************************/

/*--------------------------------------------------------------------------
diff --git a/xpp/oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c b/xpp/oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c
index 1b279d6…78a8972 100644
— a/xpp/oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c
+++ b/xpp/oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c
@@ -67,7 +67,6 @@ $Octasic_Revision: 146 $
#include “oct6100_mixer_priv.h”
#include “oct6100_conf_bridge_priv.h”

/**************************** PUBLIC FUNCTIONS *****************************/

[/code]

Thanks
riley

2

Where did that patch come from?

3

Took a bit to go back and find it but here is the link to the issue where I got the patch:

https://issues.asterisk.org/jira/browse/DAHTOOL-60

Notes on the issue now say they are working on getting it in a future relaese so that answered my question and sorry for the premature post!

riley

4

And…comments there indicate it was supposed to find its way into 2.6.2. Since it may not have, I’ve commented there.

5

The ticket’s been updated, and looks like it somehow missed 2.6.2. Apologies on that. The transition from SVN to GIT has been pretty smooth, but not without a few bumps.

6

Riley,

Would you be willing to test the next release candidate? I’ve included this patch and would like to know if it fixes your issue before the next release.
You can download it with:

git clone git://git.asterisk.org/dahdi/tools dahdi-tools
git checkout v2.6.3-rc1

7

Just an fyi thati I was able to install 2.6.3-rc1 on ubuntu 12.10 and fedora 18 with no issues!!!

Thanks for your help and let me know if you need anything else.

Riley